This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Implement Adagrad optimizer#19
Open
kaushikkanetkar wants to merge 2 commits intoNervanaSystems:masterfrom
Open
Implement Adagrad optimizer#19kaushikkanetkar wants to merge 2 commits intoNervanaSystems:masterfrom
kaushikkanetkar wants to merge 2 commits intoNervanaSystems:masterfrom
Conversation
Contributor
Author
|
Added a test in tests/test_optimizer.py |
Contributor
Author
|
Adding @zach-nervana @tyler-nervana for the review. |
Contributor
tyler-nervana
left a comment
tyler-nervana
left a comment
There was a problem hiding this comment.
If you can add a docstring for Adagrad, that'd be awesome! Regardless, this looks good to me, so I'll go ahead and get it merged internally.
|
|
||
|
|
||
| class Adagrad(LearningRateOptimizer): | ||
| """ |
Contributor
There was a problem hiding this comment.
Could you add a docstring? You can use this one as a good reference: https://github.com/NervanaSystems/neon/blob/master/neon/optimizers/optimizer.py#L637
Contributor
Author
There was a problem hiding this comment.
Sure, I'll do that
Contributor
Author
There was a problem hiding this comment.
Done. Updated. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.